Skip to content

build: enable signed commits in automated PR workflows#11195

Merged
Planeshifter merged 1 commit intodevelopfrom
philipp/fix-workflow-signing
Mar 29, 2026
Merged

build: enable signed commits in automated PR workflows#11195
Planeshifter merged 1 commit intodevelopfrom
philipp/fix-workflow-signing

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented Mar 29, 2026

Description

What is the purpose of this pull request?

This pull request:

  • enables sign-commits: true in all 12 peter-evans/create-pull-request workflow steps

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Fixes failing "Update namespace ToCs" workflow (run) caused by repository ruleset requiring verified commit signatures

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The GPG key is already imported via crazy-max/ghaction-import-gpg in each workflow, but peter-evans/create-pull-request bypasses local git config and requires its own sign-commits: true flag to create signed commits via the GitHub API.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored with Claude Code assisting in diagnosing the CI failure and applying the fix across all affected workflow files.

@stdlib-js/reviewers

@Planeshifter
build: enable signed commits in namespace ToCs workflow
d5fd874 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter marked this pull request as ready for review March 29, 2026 05:04
@Planeshifter Planeshifter requested a review from kgryte March 29, 2026 05:04
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 29, 2026
kgryte
kgryte approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 29, 2026
@Planeshifter Planeshifter merged commit 5d53095 into develop Mar 29, 2026
33 checks passed
@kgryte kgryte deleted the philipp/fix-workflow-signing branch March 29, 2026 05:10
@Planeshifter Planeshifter mentioned this pull request Mar 29, 2026
Merged
7 tasks
Planeshifter added a commit that referenced this pull request Mar 29, 2026
@Planeshifter
revert: revert enabling signed commits in automated PR workflows
0437c84 
This reverts commit 5d53095.

PR-URL: #11196
Ref: #11195

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Planeshifter added a commit that referenced this pull request Mar 29, 2026
@Planeshifter
revert: build: enable signed commits in automated PR workflows
7eae6e9 
This reverts commit 5d53095.

PR-URL: #11196
Ref: #11195

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte pushed a commit that referenced this pull request Mar 29, 2026
@Planeshifter
revert: build: enable signed commits in automated PR workflows
c0046a5 
This commit reverts #11195.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Planeshifter @kgryte @stdlib-bot